Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error messages should be more helpful #46

Open
kweide opened this issue Jul 26, 2023 · 2 comments
Open

Error messages should be more helpful #46

kweide opened this issue Jul 26, 2023 · 2 comments
Assignees

Comments

@kweide
Copy link
Member

kweide commented Jul 26, 2023

While modifying a testing configuration for debugging, I findflashxtest run-suite failing with error messages like this:

Traceback (most recent call last):
  File "/scratch/jenkins-slave/workspace/Flash-X-debug_GCC/pyenv/lib/python3.8/site-packages/FlashXTest/lib/info.py", line 132, in jobListFromNode
    if infoNode.subNodes:
AttributeError: 'NoneType' object has no attribute 'subNodes'

This appears to happen when a .suite file requests a test that isn't actually defined in the .info file.

This traceback is not helpful in locating the cause of the failure.
At a minimum, the nodeName of the offending requested test should be printed.

@kweide
Copy link
Member Author

kweide commented Jul 26, 2023

Perhaps I got that wrong, and the message was generated already at the flashxtest init stage.
It is still true that the error messages should be more informative - including an indication which command actually failed, so one isn't left wondering (while going through the output of some test job) whether it was flashxtest run-suite or flashxtest init that failed...

@kweide
Copy link
Member Author

kweide commented Jul 26, 2023

Here is another uncaught exception - this one actually happens to mention the offending name, so that is better; but the message could still be friendlier.

Traceback (most recent call last):
  File "/scratch/jenkins-slave/workspace/Flash-X-debug_GCC/pyenv/lib/python3.8/site-packages/FlashXTest/lib/info.py", line 212, in createInfo
    setupInfo = setupYaml[testSpec.setupName][testSpec.nodeName]
KeyError: 'Composite/Sedov/AMR/2dSph/Paramesh/unsplitPLM'

@akashdhruv akashdhruv self-assigned this Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants