Placeholder in IE now will display as placeholder not a default value #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonytlwu
reviewed
Nov 22, 2019
| .idea/* | ||
| .history |
There was a problem hiding this comment.
Why is this change necessary?
There was a problem hiding this comment.
@tonytlwu
I using local history module for the Visual Studio Code, which saving change history locally into .history folder. To prevent adding these changes to the repository I add this line.
There was a problem hiding this comment.
@squallstar I don't see this change in any of the other similar PRs. Are you happy with this?
There was a problem hiding this comment.
@tonytlwu yep that's fine with me, I have that plugin too installed.
squallstar
approved these changes
Nov 22, 2019
There was a problem hiding this comment.
@sofiiakvasnevska this is ready to be deployed on staging for QA.
- Risk: Low
- Affected: Widget interface on IE
- Verify: Verify the issue is resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sofiiakvasnevska
Issue
https://github.com/Fliplet/fliplet-studio/issues/5060
Description
Placeholder in IE now will display as a placeholder, not a default value
Backward compatibility
This change is fully backward compatible.
Notes
Same as in this PR