Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button Group Wrap #1491

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Button Group Wrap #1491

merged 1 commit into from
Nov 29, 2024

Conversation

cgjgh
Copy link
Contributor

@cgjgh cgjgh commented Nov 20, 2024

Description

Enable the button group widget to allow content wrapping. In the future we could add some additional code to equalize button widths for a consistent appearance. ...or feel free to give suggestions.

Screen.Recording.2024-11-20.165537.mp4

VS Current Behavior

Screen.Recording.2024-11-20.201231.mp4

Related Issue(s)

Closes #1330

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@joepavitt joepavitt self-requested a review November 22, 2024 16:43
@joepavitt
Copy link
Collaborator

joepavitt commented Nov 29, 2024

There are some border issues when this is rendered at smaller screens, but it's by no means a trivial fix to get "right", am experimenting now to see if I can resolve

Update: Going to push this ahead, can't see an obvious fix and it's not worth holding up over

@joepavitt joepavitt merged commit f07d253 into FlowFuse:main Nov 29, 2024
2 checks passed
@g7ufo
Copy link

g7ufo commented Dec 18, 2024

Thanks @cgjgh and @joepavitt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Button group is truncated
3 participants