-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed audio and MIDI drivers; encode device names as CP_UTF8 #1325
Fixed audio and MIDI drivers; encode device names as CP_UTF8 #1325
Conversation
Thanks Pedro! @tsingakbar If you have some time, could you pls. run |
CC @nanitaro , please test as well |
I ran fluidsynth.exe -Q on a test version. |
Unicode support enabled in CMake script and CLI utility
C++ example updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thank you! A few minor comments.
With these changes, the users may enjoy utf8 output and input when using cmd.exe (or other shells) in Windows. The input is relevant for Fluidsynth's own shell. And this would be enough for libfluidsynth.dll clients, like Qsynth. But there is still a loose thread: the CLI program's command line arguments are only processed/converted into utf8 for file names, but not other arguments. For instance, this would not work: C:> fluidsynth.exe -o audio.wasapi.device=GroßeStraßenlautsprecher |
Sorry for the late response, busy schedule. It looks good to me now, thanks! If you want and have some time feel free to also UTF8 convert the commandline args. @nanitaro Would you mind running If everything goes well, I would apply the commits onto the |
@derselbst Compared to the previous binary, the output result of the default device in shared and exclusive mode seems to have changed. For your information, the performance and settings of the sound devices in the test environment are as follows |
After the commits on May 1st, not only WASAPI but also the other Windows drivers are now updated to use UTF8. There is no equivalent of
The output of all these commands should be encoded now in UTF8. |
…converted to UTF8
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also sets unicode (utf8) for CLI program's console output. It should be the proper fix for #983 wasapi problems.
cc: @tsingakbar
Solves #1322