Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warn on batched_mul_generic!? #478

Open
chengchingwen opened this issue Feb 25, 2023 · 2 comments · May be fixed by #612
Open

warn on batched_mul_generic!? #478

chengchingwen opened this issue Feb 25, 2023 · 2 comments · May be fixed by #612

Comments

@chengchingwen
Copy link
Member

The batched_mul_generic! is really slow on both cpu and gpu, but somehow it isn't something easy to find. It might worth displaying a one time warning like the cuda scalar indexing warning.

@ToucheSir
Copy link
Member

Between this and #475 I wonder if we shouldn't have a more general "slow fallback" policy like other libraries do. The simplest version of this would be toggleable warnings when generic methods are called. Could this be generalized and/or made more sophisticated?

@mcabbott
Copy link
Member

mcabbott commented Nov 7, 2024

The slow paths for conv do print warnings, so batched_mul! could at least follow that.

Agree that ideally there would be a way to make these errors, like CUDA. (Whose default is now error not warning.)

Xref FluxML/Flux.jl#2454, about adding some similar switch.

@mcabbott mcabbott linked a pull request Nov 8, 2024 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants