From 41f4c1717a41844dc744e71d52f5f4a70e85468b Mon Sep 17 00:00:00 2001 From: Lyndon White Date: Thu, 28 May 2020 12:16:02 +0100 Subject: [PATCH] mark as broken the test that fails on 1.0 --- test/chainrules.jl | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/test/chainrules.jl b/test/chainrules.jl index 5fceb863c..e87d161ab 100644 --- a/test/chainrules.jl +++ b/test/chainrules.jl @@ -144,10 +144,18 @@ using Zygote, Test, ChainRules @test (1,) == h(1) - a3, pb3 = Zygote.pullback(h, 1) - @test ((1,),) == pb3(1) - end + if VERSION > v"1" + a3, pb3 = Zygote.pullback(h, 1) + @test ((1,),) == pb3(1) + else + # broken on Julia 1.0 because of https://github.com/FluxML/Zygote.jl/issues/638 + @test_broken begin + a3, pb3 = Zygote.pullback(h, 1); # line that errors + ((1,),) == pb3(1) # line actually being tested + end + end + end @testset "kwargs" begin kwfoo_rrule_hitcount = Ref(0)