-
-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Buffers.jl #645
base: master
Are you sure you want to change the base?
Use Buffers.jl #645
Conversation
I think test on 1.0 only fail because of the manifest (locally it passes). |
@MikeInnes is there anything missing or can we proceed as discussed (registering and moving to FluxML)? |
Sounds good to me. Do I need to give you owner on FluxML so you can transfer it? bors try |
tryMerge conflict. |
I think this needs a rebase |
I think I just need permissions to create a public repo in FluxML (see here). Alternatively, it might work to give you full admin rights on Buffers.jl, and then you could make the transfer |
@MikeInnes how would you like to proceed? |
for Julia 1.3, to run Zygote CI
Seems like this fell through the cracks. @sethaxen would you still be interested in bringing Buffers.jl into the Flux org? |
@ToucheSir, I'm happy to transfer the repo to the FluxML org; but given how much time has passed and how little I use Zygote now, it would probably take someone more familiar with Zygote to 1) make sure any changes that have been made in the last 1.5 years to Zygote's |
This PR fixes FluxML/ZygoteRules.jl#6 by removing
Buffer
and necessary methods that use it and instead using Buffers.jl, which contains only the code removed in this PR, the corresponding tests, and the a few additional tests. This enables users to useBuffer
in their methods/adjoints without depending on Zygote. This should not be a breaking change.A few things to do, pending feedback on this approach from @MikeInnes and others:
Buffer
tests in Zygote that are now duplicated in Buffers.jlManifest.toml