Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update current.json #928

Merged
merged 1 commit into from
May 9, 2021
Merged

Conversation

anonimusprogramus
Copy link
Contributor

Issue

Initial translation. Are the steps taken (forking, editing json, saving, create pr) OK?
Thanks

Solution and steps

Checklist

  • Add/update/check docs (code comments and docs/ folder).
  • Add/update/check tests.
  • Update/check the cli generators.

@codecov-commenter
Copy link

codecov-commenter commented May 9, 2021

Codecov Report

Merging #928 (f294d9b) into master (55b1a61) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #928   +/-   ##
=======================================
  Coverage   98.93%   98.93%           
=======================================
  Files          86       86           
  Lines        1694     1694           
  Branches      406      406           
=======================================
  Hits         1676     1676           
  Misses         18       18           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55b1a61...f294d9b. Read the comment docs.

Copy link
Member

@LoicPoullain LoicPoullain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea to split the translation into several PRs 👍

Are the steps taken (forking, editing json, saving, create pr) OK?

LGTM

@LoicPoullain LoicPoullain merged commit 046eaeb into FoalTS:master May 9, 2021
@LoicPoullain
Copy link
Member

#776

@LoicPoullain
Copy link
Member

If possible, could you prefix your future commits with [Docs] ? This makes easier to distinguish commits when looking at the history.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants