Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assembly version is 0.0.0.0 #16

Closed
ltrzesniewski opened this issue Apr 3, 2018 · 1 comment
Closed

Assembly version is 0.0.0.0 #16

ltrzesniewski opened this issue Apr 3, 2018 · 1 comment
Labels
Improvement
Milestone
1.4.1

Comments

@ltrzesniewski
Copy link
Member

The published weaver assembly version is 0.0.0.0, which causes Fody to pick the wrong EmptyConstructor version when multiple versions are available in the packages directory.

  • The Directory.Build.props file contains <GenerateAssemblyInfo>false</GenerateAssemblyInfo>
  • There's also a CommonAssemblyInfo.cs file which is not used by any project (and contains an old version number anyway)

I just noticed the outdated/unused CommonAssemblyInfo.cs issue is also present in some other addins of yours @SimonCropp, so you way want to take a look at that.
@SimonCropp SimonCropp added this to the 1.4.1 milestone Apr 3, 2018
@SimonCropp
Copy link
Member

thanks. will review other weavers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Improvement
Projects
None yet
Milestone
1.4.1
Development

No branches or pull requests
2 participants
@SimonCropp @ltrzesniewski