-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged toggle stylesheet #17
Comments
We could add that without much development, nor maintenance effort and it could be convenient to One pro from this addition would be when paired with a reusable toggle light/dark button. However, I'm not sure if this repository would be the best place for this feature as there could be multiple types of toggle button like plain JS, Angular Component, etc. If we go that way, without that toggle button idea, we'd need a name for that file that is easy to understand. What are your pros, cons, and use cases for this? |
Use case: Switching the theme without needing to include two files Pros: It's just one file We should keep the separate files and add the merged one as another file |
As much as I understand, I'm wondering if it is worth the "effort" and the additional asset; including two files should be pretty easy. That said, how would you name that new file? Quick brainstorming: |
After #15 is merged, it should be considered if creating a merged toggle stylesheet with both light and dark themes might make sense
The text was updated successfully, but these errors were encountered: