Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] No redirect back to the app #674

Closed
anisimov74 opened this issue Sep 29, 2021 · 3 comments
Closed

[Android] No redirect back to the app #674

anisimov74 opened this issue Sep 29, 2021 · 3 comments

Comments

@anisimov74
Copy link

Issue

There is no redirect back to the app, If MainActivity in the Manifest.xml contains android:taskAffinity="".
This settings should prevent possible phishing via task hijacking.


Environment

  • Your Identity Provider: IdentityServer 4
  • Platform that you're experiencing the issue on: Android
  • Pure React Native project
@anisimov74 anisimov74 changed the title No redirect [Android] No redirect back to the app Sep 29, 2021
@Jay-A-McBee
Copy link
Contributor

This sounds like it's outside the scope of this library. If the consuming app sets taskAffinity or launchMode differently, it would be the consuming app's responsibility to implement alternate handling of incoming intents.

@hpelitebook745G2
Copy link

@anisimov74 I also have this issue and verified that adding taskAffinity="" causes the redirection not to work. It was advised by our Penetration Tester to have our app add this attribute to prevent task hijacking.

Any workarounds?

@anisimov74
Copy link
Author

@hpelitebook745G2 I had to remove taskAffinity="" and live with android:launchMode="singleInstance" only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants