(next) - Prevent restoring SSR data when client has been reset #1715
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1714
This aims to fix two things
resetUrqlClient
. We do end up using a new client becauseurqlClient
prop was set to null. But due tossr.restoreData(urqlServerState)
Results are fetched from old ssr cache and network isn't called.urqlClient
prop is not null and that is the client we use. Now if you callresetUrqlClient
, we don't get anew client
because of existingurqlClient
prop value.if (urqlClient) return urqlClient