(core) - Add staleWhileRevalidate option to ssrExchange #1852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 15d856e The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
kitten
changed the title
JoviDeCroock
approved these changes
Aug 11, 2021
…1853) * add docs about staleWhileRevalidate * Apply suggestions from code review Co-authored-by: Phil Pluckthun <phil@kitten.sh> * Apply suggestions from code review Co-authored-by: Phil Pluckthun <phil@kitten.sh> Co-authored-by: Phil Pluckthun <phil@kitten.sh>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #1846
Summary
This adds a
staleWhileRevalidateoption to both thessrExchangeandnext-urql'swithUrqlClient, which allows thessrExchangeto mark a result as stale while it forcefully refetches a new server result. This is similar but different tocache-and-networkas we wouldn't recommend changing the request policy on every operation by default, which would also be ineffective as thessrExchange"imitates" full network results.Set of changes
staleWhileRevalidatetossrExchangein@urql/corestaleWhileRevalidatetowithUrqlClientinnext-urql