fix(core): Handle text/* type fetch responses #2456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The outer `catch` was still responsible for handling errors, so we can avoid duplication here and still use `statusText`. We should instead add a separate case for `text/*` contents. Those should never really be returned by endpoints, but if they are we can return them as it was in this branch before.
🦋 Changeset detectedLatest commit: 11d472b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
JoviDeCroock
approved these changes
May 24, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #2442
Reopen of #2444
Summary
This adds special handling for
text/*responses. Optimally, a GraphQL endpoint should never under normal circumstances return a text response.Also, adding a separate case for cases where
JSON.parsefails leads to two things:Instead, we can add a special case for
text/*to explicitly return the result then and otherwise keep our old logic.Furthermore, in case
response.statusTextisn't present, we can add another fallback case of passing through theoriginal error.
Set of changes
text/*handling tofetchSource