Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

animationWhitelist as a prop #1186

Closed
boygirl opened this issue Nov 18, 2018 · 5 comments
Closed

animationWhitelist as a prop #1186

boygirl opened this issue Nov 18, 2018 · 5 comments

Comments

@boygirl
Copy link
Contributor

boygirl commented Nov 18, 2018

From @bear-junior on November 17, 2018 9:46

Hi! :)

Is there any chance that animationWhitelist will be a prop for all charts with animate? Sometimes I don't want to have style animation, it's laggy sometimes, but for example I want to animate only height of bars and I have opacity on it, but I don't want to animate opacity.

Copied from original issue: FormidableLabs/victory-native#418

@boygirl
Copy link
Contributor Author

boygirl commented Nov 18, 2018

@bear-junior Thanks for this issue. I think it's a good idea. I'm going to move this to the main victory repo, though since the work will be done there.

@boygirl
Copy link
Contributor Author

boygirl commented Nov 18, 2018

This feature involves adding an animationWhitelist prop to all components that animate. When this prop is not provided, the existing fallback will be used.

@bear-junior
Copy link

🙏🏻🙏🏻🙏🏻

@michaelbridge
Copy link

👍 👍 👍

@boygirl
Copy link
Contributor Author

boygirl commented Jan 8, 2019

Released as victory@31.1.0

@boygirl boygirl closed this as completed Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants