Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch big error after installed the latest victory version #1260

Closed
TeresaZhang7517 opened this issue Feb 28, 2019 · 1 comment · Fixed by #1271
Closed

Catch big error after installed the latest victory version #1260

TeresaZhang7517 opened this issue Feb 28, 2019 · 1 comment · Fixed by #1271

Comments

@TeresaZhang7517
Copy link

Bugs and Questions

The Problem

Catch a big error after installed the latest victory version. Details as below. Could help to solve this issue? Thanks very much.

Description

image
image
@boygirl
Copy link
Contributor

boygirl commented Mar 12, 2019

@TeresaZhang7517 Hi there! I'm guessing this is caused by a different version of prop-types, but I will release a patch that changes the prop declaration back to the more common shape instead of exact

@boygirl boygirl mentioned this issue Mar 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use prop types shape instead of exact FormidableLabs/victory
2 participants
@boygirl @TeresaZhang7517