Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VictoryArea stroke vanishes in polar chart #1265

Closed
4 tasks done
mettjus opened this issue Mar 5, 2019 · 0 comments
Closed
4 tasks done

VictoryArea stroke vanishes in polar chart #1265

mettjus opened this issue Mar 5, 2019 · 0 comments

Comments

@mettjus
Copy link
Contributor

mettjus commented Mar 5, 2019

Bugs and Questions

Checklist

  • This is not a victory-native specific issue.

  • I have read through the FAQ and Guides before asking a question

  • I am using the latest version of Victory (v32.0.0)

  • I've searched open issues to make sure I'm not opening a duplicate issue

The Problem

VictoryArea stroke vanishes when used in polar chart in both the following cases:

  • when explicitly applying a color via stroke: "some-color"
  • when setting fill to "none" in the attempt to only keep the stroke (e.g. to prevent the area from block pointer events)

In the first scenario, I would expect to be able to explicitly set a stroke color without the stroke going away. In the second I would expect the fill to be gone with the stroke still in place.

Reproduction

Both described scenarios can be reproduced here by modifying lines 17 and 18: https://codesandbox.io/s/04pp61m890

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant