Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strokeLinejoin style being stripped out from data styles in VictoryBar #995

Closed
4 tasks done
ebrillhart opened this issue May 7, 2018 · 2 comments
Closed
4 tasks done

Comments

@ebrillhart
Copy link
Contributor

Bugs and Questions

Checklist

  • This is not a victory-native specific issue. (Issues that only appear in victory-native should be opened here)

  • I have read through the FAQ and Guides before asking a question

  • I am using the latest version of Victory

  • I've searched open issues to make sure I'm not opening a duplicate issue

The Problem

I created a few bar charts a few months back with data styles including strokeLinejoin: round, which worked great. Those charts no longer have rounded ends, and the style isn't present in the DOM inspector, although I can add it there and it renders as expected. It seems like it may be getting stripped out of the whitelisted style attributes being passed to the svg components.

Reproduction

Reproduction of the issue here.

@chrisbolin
Copy link
Contributor

possibly addressed by FormidableLabs/victory-core#364. released in victory-core 22.0.0 and victory 0.26.0. Emma will check it out

@boygirl
Copy link
Contributor

boygirl commented May 20, 2018

Indeed, this should be solved by FormidableLabs/victory-core#364. I'm going to close this issue, but @ebrillhart if you're still hung up on this, please pester me.

@boygirl boygirl closed this as completed May 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants