Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shared library build #36

Closed
Francesco149 opened this issue May 23, 2018 · 3 comments
Closed

shared library build #36

Francesco149 opened this issue May 23, 2018 · 3 comments

Comments

@Francesco149
Copy link
Owner

Francesco149 commented May 23, 2018

since projects such as the live pp counter are compiling oppai to a shared library I'd like to have an upstream build so they don't have to fork it.

this was attempted before by #8

but it needs to work on both windows and *nix and no makefile

should be as easy as defining some OPPAIAPI macro to __declspec(dllexport) on windows and nothing on *nix and giving it to all interface functions and adding a flag to the build scripts for shared lib mode

maybe even make it so you can compile as a static lib

@Francesco149
Copy link
Owner Author

this is almost working. already tested on linux, windows build needs to be fixed so i gotta boot into windows, fix the libbuild.bat and test it

@Francesco149
Copy link
Owner Author

so the windows shared library build works fine but appveryor can't build it????

it just seems to try and call lib with invalid arguments, must be something appveryor's msvc is missing https://ci.appveyor.com/project/Francesco149/oppai-ng/builds/20211615#L159

@Francesco149
Copy link
Owner Author

ok so im stupid, there's a random lib call after libbuild.bat in release.ps1, i have no idea how that ended up there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant