Java Frontend: EnumDeclarations do not get any content other than entries

[robinmaisch]

Hello CPG team,
the de.fraunhofer.aisec.cpg.frontends.java.DeclarationHandler ignores the members of enumDecl in the method handleEnumDeclaration, so any new EnumDeclaration does not get any fields, methods, constructors that it may need.
Import statements are also not considered, unlike for records.

I copied and adapted the relevant parts of handleClassOrInterfaceDeclaration (lines ~227-303) over to handleEnumDeclaration, and that seemed to work quite well as a start, but I could not get it to work completely in the end.
I hope you can have a look into it.

[konradweiss]

Hi :) Thanks for reporting the Issue. I will look into it and find out what the best option is there. I assume you mean in the Java language Frontend?

[konradweiss]

If you have a specific piece of code that shows the issue I'd love to test it out.

[robinmaisch]

Yes, here's a sample class. For me, the resulting EnumDeclaration has no methods or fields, only the two entries are present.

GitHub wouldn't let me upload a .java file, so here's the file zipped.
Enums.zip

Here's the content:

public enum Enums {

    VALUE_ONE(1),
    VALUE_TWO(2);

    private int value;
    public static final String NAME = "Enums";

    Enums(int value) {
        this.value = value;
    }

    public int getValue() {
        return value;
    }
    public static void main(String[] args) {
        Enums e = Enums.VALUE_ONE;
        Enums e2 = Enums.VALUE_TWO;
    }
}

[konradweiss]

Thanks for that :) if you already have something that is not finished but shows an approach that you would follow you can submit a draft PR and signal what is missing or still not working.

[robinmaisch]

It turned out my approach did work, it was only my test that was wrong. Have a look :)