Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move connecting of declaration and definition to C++ extra pass #1484

Closed
oxisto opened this issue Mar 29, 2024 · 1 comment · Fixed by #1482 or #1505
Closed

Move connecting of declaration and definition to C++ extra pass #1484

oxisto opened this issue Mar 29, 2024 · 1 comment · Fixed by #1482 or #1505
Labels
cxx Related to C/C++ language parsing enhancement New feature or request

Comments

@oxisto
Copy link
Member

oxisto commented Mar 29, 2024

Currently, connecting declarations and definitions is done in the frontend, which might have a limited view and is not really a clean approach. Instead, this should be moved to the already existing CXXExtraPass, potentially even into a completely language neutral pass, but we are currently only filling the definition field for C++.

It also seems to be somewhat untested, so test coverage should be improved as well.
@oxisto oxisto added enhancement New feature or request cxx Related to C/C++ language parsing labels Mar 29, 2024
@oxisto oxisto linked a pull request Mar 29, 2024 that will close this issue
C++ translation improvements #1482
Merged
@oxisto oxisto mentioned this issue Mar 29, 2024
Merged
@oxisto oxisto mentioned this issue Apr 5, 2024
Merged
@oxisto oxisto linked a pull request Apr 5, 2024 that will close this issue
Extracting connecting declarations and definitions in C++ to extra pass #1505
Merged
@oxisto
Copy link
Member Author

oxisto commented Apr 5, 2024 •
edited
Loading

Closed by #1505

Also was sort of duplicate of #194

@oxisto oxisto closed this as completed Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cxx Related to C/C++ language parsing enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@oxisto