Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smaller fixes in logging and utils #1288

Merged
merged 2 commits into from
Aug 30, 2023
Merged

Smaller fixes in logging and utils #1288

merged 2 commits into from
Aug 30, 2023

Conversation

oxisto
Copy link
Member

@oxisto oxisto commented Aug 23, 2023

This PR fixes smaller things such as proper display of the log source by inlining the log functions. It also fixes other smaller issues.

@oxisto oxisto requested a review from konradweiss as a code owner August 23, 2023 07:44
Copy link
Collaborator

@konradweiss konradweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clarify the removal of the Thread.interrupt

@oxisto oxisto requested a review from konradweiss August 28, 2023 10:51
@oxisto oxisto force-pushed the smaller-fixes branch 3 times, most recently from ae047ef to 1e5c188 Compare August 29, 2023 18:54
This PR fixes smaller things such as proper display of the log source by inlining the log functions. It also fixes other smaller issues.
@sonarcloud
Copy link

sonarcloud bot commented Aug 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

76.9% 76.9% Coverage
0.0% 0.0% Duplication

@konradweiss konradweiss merged commit 4308616 into main Aug 30, 2023
3 checks passed
@konradweiss konradweiss deleted the smaller-fixes branch August 30, 2023 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants