More precise types in arithmetic evaluation #1290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxisto
force-pushed
the
more-precise-arithmetic-types-in-evaluation
branch
3 times, most recently
from
32715c7 to
1abe50a
Compare
oxisto
force-pushed
the
more-precise-arithmetic-types-in-evaluation
branch
4 times, most recently
from
7abad9d to
47ba5fd
Compare
Previously, we just casted most of our numeric types to `Long` when doing arithmetic operations in the `ValueEvalutor`. This PR tries to optimize that, to at least keep the type if both are the same. It is still somewhat inprecise when two different types of different bitwidth are involved. In these cases we mostly just still cast to `Long`.
oxisto
force-pushed
the
more-precise-arithmetic-types-in-evaluation
branch
from
47ba5fd to
d0c4ea0
Compare
|
Kudos, SonarCloud Quality Gate passed! |
KuechA
approved these changes
Aug 28, 2023
|
We may want to add a note to our gh page and say that the evaluation could return different types of numbers. This means that it might be required/useful to transfer the value e.g. via |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we just casted most of our numeric types to
Longwhen doing arithmetic operations in theValueEvalutor. This PR tries to optimize that by introducing a number of extension functions that under the hood call the necessary Kotlin functions to properly deal with the resulting type based on the bit width.