Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed dependency org.jetbrains:annotations #1355

Merged
merged 3 commits into from
Nov 16, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Nov 16, 2023

Not longer needed

@oxisto
Copy link
Member

oxisto commented Nov 16, 2023

Since we are now purely Kotlin based. Is this even still needed?

@oxisto oxisto changed the title Update dependency org.jetbrains:annotations to v24.1.0 Removed dependency org.jetbrains:annotations Nov 16, 2023
@oxisto oxisto enabled auto-merge (squash) November 16, 2023 08:32
@oxisto oxisto force-pushed the renovate/org.jetbrains-annotations-24.x branch from 8f809d1 to ecc45c5 Compare November 16, 2023 08:33
Copy link
Contributor Author

renovate bot commented Nov 16, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@konradweiss
Copy link
Collaborator

Since we are now purely Kotlin based. Is this even still needed?

If we don't we can definitely remove it

@oxisto oxisto force-pushed the renovate/org.jetbrains-annotations-24.x branch from ecc45c5 to 4c6fe1f Compare November 16, 2023 09:00
Copy link

sonarcloud bot commented Nov 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@oxisto oxisto merged commit 0770194 into main Nov 16, 2023
4 checks passed
@oxisto oxisto deleted the renovate/org.jetbrains-annotations-24.x branch November 16, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants