Better design of the CodeAndLocationProvider
#1414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of directly setting the code and location provider in the implementation of the `CodeAndLocationProvider` we rather now have an implementor of this interface implement the methods `codeOf` and `locationOf` and set the code/location in the node builder. This is more in line with the other providers, since they should *provide* a value, but not *set* it. The function `setCodeAndLocation` will stay for now for legacy reason and is marked deprecated. We seem to have a lot of language frontends that directly call this function, which is bad design anyway. One should supply the raw node to the node builder instead.
oxisto
force-pushed
the
better-location-provider
branch
from
630db6b to
e0a6d48
Compare
|
konradweiss
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of directly setting the code and location provider in the implementation of the
CodeAndLocationProviderwe rather now have an implementor of this interface implement the methodscodeOfandlocationOfand set the code/location in the node builder. This is more in line with the other providers, since they should provide a value, but not set it.