Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only follow full DFG flow in followNextDFGEdgesUntilHit and similar #1473

Merged
merged 3 commits into from
Mar 27, 2024

Conversation

oxisto
Copy link
Member

@oxisto oxisto commented Mar 23, 2024

We had a problem that the extension functions, such as followNextDFGEdgesUntilHit were following all DFG flows, including partial ones. This lead to unexpected results.

@oxisto oxisto requested a review from konradweiss as a code owner March 23, 2024 21:29
@oxisto oxisto force-pushed the only-follow-full-dfg branch 2 times, most recently from 96a831c to c93e71d Compare March 23, 2024 21:39
@oxisto oxisto requested a review from KuechA as a code owner March 23, 2024 21:39
@oxisto oxisto force-pushed the only-follow-full-dfg branch 3 times, most recently from 31b02a2 to b5701d2 Compare March 23, 2024 22:10
We had a problem that the extension functions, such as `followNextDFGEdgesUntilHit` were following all DFG flows, including partial ones. This lead to unexpected results.
@oxisto oxisto force-pushed the only-follow-full-dfg branch from b5701d2 to 192351d Compare March 23, 2024 22:11
@oxisto oxisto requested a review from konradweiss March 27, 2024 07:15
Copy link

sonarcloud bot commented Mar 27, 2024

@konradweiss konradweiss merged commit c831147 into main Mar 27, 2024
3 checks passed
@konradweiss konradweiss deleted the only-follow-full-dfg branch March 27, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants