Fixing placement of inferred record declarations #1515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxisto
force-pushed
the
use-correct-scope-in-record-inference
branch
3 times, most recently
from
a2ae92e to
3dfe18b
Compare
Before this PR, we inferred all record declarations into the global scope, even though we knew (because of the FQN) that the record is part of another "name" (e.g. a namespace). This PR fixes that and correctly places the inferred record in the extracted scope of its FQN.
oxisto
force-pushed
the
use-correct-scope-in-record-inference
branch
from
4af96d4 to
7e9487b
Compare
oxisto
force-pushed
the
use-correct-scope-in-record-inference
branch
from
7e9487b to
43c94ef
Compare
KuechA
reviewed
Apr 12, 2024
cpg-core/src/main/kotlin/de/fraunhofer/aisec/cpg/passes/SymbolResolver.kt
Show resolved
Hide resolved
KuechA
approved these changes
Apr 12, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, we inferred all record declarations into the global scope, even though we knew (because of the FQN) that the record is part of another "name" (e.g. a namespace). This PR fixes that and correctly places the inferred record in the extracted scope of its FQN.