Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ast.Subscript and ast.Slice #1545

Merged
merged 6 commits into from
Apr 23, 2024
Merged

Implement ast.Subscript and ast.Slice #1545

merged 6 commits into from
Apr 23, 2024

Conversation

maximiliankaul
Copy link
Contributor

@maximiliankaul maximiliankaul self-assigned this Apr 23, 2024
@maximiliankaul maximiliankaul mentioned this pull request Apr 23, 2024
Closed
@immqu
Copy link

immqu commented Apr 23, 2024

Thanks, I have tested the changes using the PPG and it works now!

@maximiliankaul maximiliankaul changed the title implement ast.Subscript (still missing ast.Slice) Implement ast.Subscript and ast.Slice Apr 23, 2024
@KuechA KuechA enabled auto-merge (squash) April 23, 2024 13:54
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@KuechA KuechA merged commit 0198042 into main Apr 23, 2024
3 checks passed
@KuechA KuechA deleted the mk/issue1542 branch April 23, 2024 14:02
@oxisto oxisto linked an issue Apr 23, 2024 that may be closed by this pull request
Python ExpressionHandler does not handle ASTSubscript #1542
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KuechA KuechA KuechA approved these changes

Assignees

@maximiliankaul maximiliankaul

Labels
python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python ExpressionHandler does not handle ASTSubscript
3 participants
@maximiliankaul @immqu @KuechA