Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Videos that aren't 16:9 are cut off by the bottom of the screen. #959

Closed
saddude35 opened this issue Jan 19, 2021 · 23 comments · Fixed by #4978
Closed

Videos that aren't 16:9 are cut off by the bottom of the screen. #959

saddude35 opened this issue Jan 19, 2021 · 23 comments · Fixed by #4978
Labels
bug Something isn't working

Comments

@saddude35
Copy link

saddude35 commented Jan 19, 2021

Hello, the recent update removed the black bars from the sides of the videos. Some videos that were uploaded in an odd aspect ratio like the one example below become cut off at the bottom. I understand some people don't like the black bars, but is there a way to make them toggle-able for people who prefer them? I don't know if it'll help but I my laptop's display is 1080p and my display scaling is set to 125%. Thanks for all the hard work.

Screenshots
FreeTube_XJChwiZLZV
FreeTube_yjM3HHYgMx
FreeTube_ldQDNJ0PzV
FreeTube_ocqYkh9Ue8

Videos are cut off even more with theatre mode enabled.

Example with theatre mode enabled:

r5mBHhIQVF.mp4

Example with theatre mode disabled:

5g7mHkwHj3.mp4

Environment Information

  • OS: Windows 10 Enterprise LTSC
  • OS Version: 1809
  • FreeTube version: 11.1
  • Installation Method: Portable
  • Primary API Used: Local API
@saddude35 saddude35 added the bug Something isn't working label Jan 19, 2021
@PrestonN
Copy link
Member

This should be fixed in the dev branch. Will be included in the next release.

@WhereAreDoggo
Copy link

WhereAreDoggo commented Mar 12, 2021

Since this hasn't been resolved in the subsequent releases, the issue should be reopened. Possibly re-tagging it as a feature request.

@Gorrrg
Copy link

Gorrrg commented Sep 14, 2023

This still is an issue. Example: https://youtu.be/p_P5EK1aqZg
I'm on the latest build 3448 atm

@absidue absidue reopened this Sep 14, 2023
@efb4f5ff-1298-471a-8973-3d47447115dc

@Gorrrg could u mabe screenrecord what u see in that video u linked so i can compare with my results

@Gorrrg
Copy link

Gorrrg commented Sep 25, 2023

Sure

2023-09-25_21-25-11_FreeTube_Every_barbed_wire_fence_from_the_original_Mission__new

The FreeTube window was maximized here at 3840x2067
I'm on the current latest build 3500

@efb4f5ff-1298-471a-8973-3d47447115dc

Did u maximize the window by changing settings within FT or did u do that within your system settings?

@Gorrrg
Copy link

Gorrrg commented Sep 25, 2023

2023-09-25_21-45-01_FreeTube_Subscriptions_-_FreeTube No, I maximized it by clicking the maximize button in the title bar of the application window.

@efb4f5ff-1298-471a-8973-3d47447115dc

Hmm okay my window maximized is 1920x1080 and it looks normal to me so maybe this is an issue with big screens/resolutions?

@Gorrrg
Copy link

Gorrrg commented Sep 25, 2023

Maybe somewhere in the code there's a constant pixel width instead of a view-width or something like that.

@github-actions
Copy link
Contributor

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@WhereAreDoggo
Copy link

WhereAreDoggo commented Nov 13, 2023

I used to have the issue at the time (for 1920x1080) and it appears to be fixed for me.

Copy link
Contributor

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

Copy link
Contributor

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

Copy link
Contributor

github-actions bot commented Feb 8, 2024

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

Copy link
Contributor

github-actions bot commented Mar 8, 2024

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

Copy link
Contributor

github-actions bot commented Apr 9, 2024

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

Copy link
Contributor

github-actions bot commented May 8, 2024

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

Copy link
Contributor

github-actions bot commented Jun 7, 2024

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

Copy link
Contributor

github-actions bot commented Jul 6, 2024

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@CodingMadness
Copy link

Is this not fixed yet?

@juanmbt
Copy link

juanmbt commented Jul 19, 2024

Still seeing this issue on v0.21.1.

As the playback controlls are cut out, you need to scroll down to access them.

Copy link
Contributor

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@trobertson
Copy link

Could it be this line? That * 1.78 would let the player grow much larger than the viewable vertical area.

.videoPlayer {
    ...
    max-inline-size: calc(80vh * 1.78);
    ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

9 participants