Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point out the mistake in solution provided for homework from video titled "Making Your Own Shot and Pass Maps" #1

Open
Ujjval-Patel opened this issue Jul 3, 2020 · 0 comments

Comments

@Ujjval-Patel
Copy link

First of all, I would like to say kudos, you are doing a wonderful job. ( feeling inarticulate to express my gratitude ).

Although. In the video titled, "Making Your Own Shot and Pass Maps". David provided the solution of how passes where plotted. Now I was trying to see recreate similar map for Dani Carvajal famous cross from which Cristiano Ronaldo scored that famous bicycle kick in the champions league semifinal. But to my surprise, there was no such 'pass' created by 'Dani Carvajal'. Here's my observation.

  1. Solution provided by David.
    passArrow = plt.Arrow(x,pitchWidthY-y,dx,dy, width=3, color="blue")
    result
    2 dani_carvajal_passes_juv_vs_rm

  2. Correct code in my opinion.
    passArrow = plt.Arrow(x,pitchWidthY-y,dx,-dy, width=3, color="blue")
    result
    2 dani_carvajal_passes_juv_vs_rm_corrected

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant