Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessing tested application services easily via driver's service container #116

Merged

Conversation

pamil
Copy link
Member

@pamil pamil commented Apr 4, 2020

Fixes #86, fixes #110.

TODO:

  • Documentation

Given the counter service is zeroed
When I visit the page "/hello-world"
Then the counter service should return 1

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line to remove.


Scenario: Accessing a service from driver's service container (manually injected dependencies)
Given a YAML services file containing:
"""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation.


Scenario: Accessing a service from driver's service container (autowired & autoconfigured dependencies)
Given a YAML services file containing:
"""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation.

@pamil pamil force-pushed the 2.1-accessing-drivers-service-container branch from fed405e to e94285d Compare April 4, 2020 13:44
@alanpoulain
Copy link
Contributor

🎉 Thank you very much for implementing this feature!

@pamil
Copy link
Member Author

pamil commented Apr 4, 2020

Thanks for your patience and code review 🎈

@pamil pamil merged commit 13b81e2 into FriendsOfBehat:master Apr 4, 2020
@pamil pamil deleted the 2.1-accessing-drivers-service-container branch April 4, 2020 13:53
@Chrisissorry
Copy link

Thanks for implementing, we'll check it out! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting different service injected into context Provide a way to access the isolated Mink kernel services
3 participants