Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for PHP 8 #134

Merged
merged 5 commits into from
Nov 5, 2020
Merged

Add support for PHP 8 #134

merged 5 commits into from
Nov 5, 2020

Conversation

dunglas
Copy link
Contributor

@dunglas dunglas commented Oct 30, 2020

No description provided.

@dunglas dunglas marked this pull request as ready for review October 30, 2020 15:24
@dunglas
Copy link
Contributor Author

dunglas commented Oct 30, 2020

Tests pass locally when passing --ignore-platform-reqs to composer.

@dunglas dunglas mentioned this pull request Oct 30, 2020
Merged
@dunglas
Copy link
Contributor Author

dunglas commented Nov 2, 2020

All green 🎆. This is ready to be merged!

pamil added a commit to FriendsOfBehat/PageObjectExtension that referenced this pull request Nov 5, 2020
@pamil
feature #16 allow PHP 8 (dunglas)
bd03532 
This PR was merged into the 1.0-dev branch.

Discussion
----------

Follows FriendsOfBehat/SymfonyExtension#134

Commits
-------

4c35f9d allow PHP 8
@pamil pamil merged commit 62172ef into FriendsOfBehat:master Nov 5, 2020
@pamil
Copy link
Member

pamil commented Nov 5, 2020

Thank you, Kévin! 🥇

@dunglas dunglas deleted the php8 branch November 5, 2020 23:26
@dunglas
Copy link
Contributor Author

dunglas commented Nov 5, 2020

Thanks for merging! By the way, you should migrate to Travis.com (instead of Travis.org), because the .org domain will be closed down on December 31st: https://mailchi.mp/3d439eeb1098/travis-ciorg-is-moving-to-travis-cicom

@pamil
Copy link
Member

pamil commented Nov 6, 2020

@dunglas already switched to GitHub Actions, thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lchrusciel lchrusciel lchrusciel approved these changes

@pamil pamil pamil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dunglas @pamil @lchrusciel