-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating Sveltekit/Vite now throws: request in handle has been replaced with event. See https://github.com/sveltejs/kit/pull/3384 for details
#9
Comments
@inspiredlabs Yes there are some incompatibilities with the new sveltekit. I have done fixes on a local copy so far but have been a bit too busy to complete a clean work to push back. Hopefully, I'll find time this weekend. I'll try to give more info on here in a few hours if you want to put them in by hand yourself in your project. |
I have a working local fixed version. I need to check it works correctly as a PWA and then I will push it. PS: I pushed it but cannot deploy it to Vercel for testing. It builds correctly locally but not on Vercel. |
I got the deployment working on Vercel following a Sveltekit installation and merge – see:
It works!NB: there are two requirements here:
|
Two things:
PS: Third thing, I am not seeing |
Mea culpa, for the shorthand, what I meant was: |
A PR won't work as there are many changes to Sveltekit. Here's how to get it working:
Feel free to clone this public repo, if I have missed something in the instructions. |
I have done some changes to the config.json and it seems it does address my deployment issues. I will push the changes after a bit of clean up. |
The changes have been pushed. Unless you see anything else, I will close this issue tomorrow. |
Closing this issue. |
I am trying to use SveltekitPWA with the Vite/Svelte inspector, which is available using an entry to
svelte.config.js
:However, merging SveltekitPWA with the latest Sveltekit, highlights breaking changes – notably:
hooks.ts
throws: sveltejs/kit#3384.Have you had a chance to look at the new interface?
Repo: https://github.com/inspiredlabs/inspector
demo: https://offline-phi.vercel.appThe text was updated successfully, but these errors were encountered: