Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Report: Pico only burps once at the end of South (Pico Mix) #3385

Closed
2 tasks done
Hundrec opened this issue Sep 19, 2024 · 18 comments
Closed
2 tasks done

Bug Report: Pico only burps once at the end of South (Pico Mix) #3385

Hundrec opened this issue Sep 19, 2024 · 18 comments
Assignees
Labels
status: bug reproduced Involves a bug which can be reliably reproduced by reviewers. type: minor bug Involves a minor bug or issue.

Comments

@Hundrec
Copy link
Contributor

Hundrec commented Sep 19, 2024

Issue Checklist

  • I have properly named the issue
  • I have checked the issues/discussions pages to see if the issue has been previously reported

What platform are you using?

Itch.io (Downloadable Build) - Windows

If you are playing on a browser, which one are you using?

None

Version

0.5.0

Context (Provide images, videos, etc.)

I found it odd that Pico plays the burping animation once at the end of South, but not the second time.

As it turns out, burpShit plays
image

...but burpSmile doesn't play right afterwards
image

However, burpSmile plays just fine at the beginning of Guns
image

Here's a video of the animations:
https://github.com/user-attachments/assets/77203677-1025-482e-9121-45b01fb3278d

Steps to reproduce (or crash logs, errors, etc.)

Play South (Pico Mix)

@Hundrec Hundrec added status: pending triage The bug or PR has not been reviewed yet. type: minor bug Involves a minor bug or issue. labels Sep 19, 2024
@lemz1
Copy link
Contributor

lemz1 commented Sep 19, 2024

A virus again?
This is like the second time in this repo

@Hundrec
Copy link
Contributor Author

Hundrec commented Sep 19, 2024

Uh huh, reporting right now

@Hundrec
Copy link
Contributor Author

Hundrec commented Sep 19, 2024

Scammers be like:

Install this virus to make Pico burp twice

@IdealistCat
Copy link

IdealistCat commented Sep 22, 2024

I think this issue is just a cause of the animation not existing for the character of pico-dark

@EliteMasterEric EliteMasterEric added status: bug reproduced Involves a bug which can be reliably reproduced by reviewers. and removed status: pending triage The bug or PR has not been reviewed yet. labels Sep 22, 2024
@Hundrec
Copy link
Contributor Author

Hundrec commented Sep 23, 2024

I think this issue is just a cause of the animation not existing for the character of pico-dark

I investigated pico-dark.json, pico_dark.png, and pico_dark.xml and found the animation in all of them. Something's just not working somewhere along the way!

@IdealistCat
Copy link

wrong anim name

@IdealistCat
Copy link

??

@OrbyyOrbinaut
Copy link

Running into this same issue but with a mod I'm working on rn, my guess is maybe its an issue with forcing the animation perhaps?

@OrbyyOrbinaut
Copy link

It seems like the issue has to do when you force an animation to play when a forced one is already playing (for the event at least, not sure if this is an issue otherwise)

@Hundrec
Copy link
Contributor Author

Hundrec commented Sep 24, 2024

You're right! I disabled forcing for the burpShit animation and it allowed burpSmile to play. Turns out the burpShit animation just lasts longer than it needs to and overrides following animations for nearly two bars.

burpShit.unnforced.mp4

@OrbyyOrbinaut
Copy link

OrbyyOrbinaut commented Sep 24, 2024

This only half the issue, What happens right now is trying to play two forced animations in a row causes the second forced one to not play for whatever reason. (This didn't happen on 0.4.1 so I assume the current behavior is a bug)

@Hundrec
Copy link
Contributor Author

Hundrec commented Sep 24, 2024

This has always been the case, refer to #2670

@OrbyyOrbinaut
Copy link

Oh huh, never knew.

@github-staff github-staff deleted a comment from Kami-prog Sep 25, 2024
@IdealistCat
Copy link

that's weird

@Hundrec
Copy link
Contributor Author

Hundrec commented Sep 30, 2024

Resolved in 0.5.1, perhaps by shortening the length of burpShit

@Hundrec Hundrec closed this as completed Sep 30, 2024
@IdealistCat
Copy link

probably

@AbnormalPoof
Copy link
Contributor

I feel like to solve another issue like this in the future, would it be more feasible if the “Force” toggle also cancels any forced animations? I’m not really sure.

@Hundrec
Copy link
Contributor Author

Hundrec commented Oct 4, 2024

I feel like to solve another issue like this in the future, would it be more feasible if the “Force” toggle also cancels any forced animations? I’m not really sure.

I've thought about how the "Force" feature should really work.
I think we could benefit from having two separate levels of forcing:

  • One that overrides animations like the "Force" we have now
  • One that overrides all other animations including the above Forced animations (an "Absolute Force" of sorts)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: bug reproduced Involves a bug which can be reliably reproduced by reviewers. type: minor bug Involves a minor bug or issue.
Projects
None yet
Development

No branches or pull requests

7 participants