Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Report: Faster song progression problem #3500

Closed
2 tasks done
Blue2359 opened this issue Sep 30, 2024 · 13 comments
Closed
2 tasks done

Bug Report: Faster song progression problem #3500

Blue2359 opened this issue Sep 30, 2024 · 13 comments
Labels
status: pending triage The bug or PR has not been reviewed yet. type: minor bug Involves a minor bug or issue.

Comments

@Blue2359
Copy link

Blue2359 commented Sep 30, 2024

Issue Checklist

  • I have properly named my issue
  • I have checked the Issues/Discussions pages to see if my issue has already been reported

Platform

Newgrounds (Web/HTML5)

Browser

Other (Specify in Description field)

Version

0.5.1

Description (include any images, videos, errors, or crash logs)

Unless I'm tripping, the songs in the 0.5.1 patch update seem to progress a little tiny bit faster than original, but still fast enough to notice something unusual going on, there's also slightly audible clipping noises (which arise from I assume the vocals), while the song is progressing, which can get a bit annoying overtime, I guess.

I did some tests playing some songs on Desktop; (running on version 0.5.0), and on Web; (running on version 0.5.1),
and there does seem to be some lil' differences between each other:

image

I didn't really calculate the math between these song times, so the 3.5%ish thing I just winged from my head.
This issue might be coming from this PR here #3384, which was merged with the 0.5.1 patch update.

Which might mean that the re-sync check causes the song to progress a realllyyyy tiny bit further while
also trying to sync the vocals with the song time, or whatever if I'm getting this correctly...

I haven't tried a Desktop build of the 0.5.1 patch update, but I would assume it behaves the same as the Web build.
(Edit 1: I've been told that it actually doesn't behave like this on Desktop, but I've yet to try it out.)
(Edit 2: It does seem to be behaving the same.)

(Also note that my Offsets; (Visual & Input) were both set to 0ms on both platforms during these tests!)
Web Browser being used: Brave

Steps to Reproduce

There's not really a reproduction method, you just have to play a song in the 0.5.1 patch update.
Everything for it are basically documented in the description already.

@Blue2359 Blue2359 added status: pending triage The bug or PR has not been reviewed yet. type: minor bug Involves a minor bug or issue. labels Sep 30, 2024
@NotHyper-474
Copy link
Contributor

NotHyper-474 commented Sep 30, 2024

Yeah I'm on Firefox and also noticed this. Even the audio clipping. Doesn't appear to happen on the Desktop build tho.

@JackXson-Real
Copy link

Ive noticed this as well lol

@Kade-github
Copy link
Contributor

I'll have to test later but this could be because of how the game now resyncs more often, from my pr. But otherwise if it has no instrumental offset, nothing should have changed.

Again i'll have to check, as I did test my pr on browser really quickly but not in depth.

@Hundrec
Copy link
Contributor

Hundrec commented Oct 3, 2024

After playing the game on both a PC and a laptop at the same time (both set to 300 fps), I've found that devices with weaker performance lag behind over the course of the song. I think this has to do with the actual framerate the device is reaching as well as its load times for assets and events.

Maybe running this timing test with different framerate caps and different levels of processing power would yield different results?

@Shaunyman
Copy link

I've been having the same problem as well. V0.5.0 worked normally on web, but v0.5.1 has every song sped up. Strangely, my friend is not having this issue when he plays the web version on his computer. We even did a side by side comparison using discord screen share to see the difference and mine was definitely faster. I calculated that there is a roughly 6% increase to the tempo of each song using the tutorial as the control. The tutorial has a tempo of 100bpm and my sped up version is roughly 106bpm. Not sure that this information will be useful, but figured I should put it out there.

@ThatGreenBlur
Copy link

ThatGreenBlur commented Oct 3, 2024

On my lower end device playing the desktop version, the frame pacing is atrocious and has so much stutters and rewinds or random offsetting unlike v0.5.0

@macmacfire
Copy link

macmacfire commented Oct 5, 2024

This is particularly noticeable, at least to me, on Bopeebo Erect, and Thorns both Erect and not. I don't know if each song is sped up differently but it seems like it to me.

@Shaunyman
Copy link

This issue has been fixed for me in v0.5.2

@NotHyper-474
Copy link
Contributor

This issue has been fixed for me in v0.5.2

Maybe the changes done in #3546 accidentally fixed this

@Shaunyman
Copy link

This issue has been fixed for me in v0.5.2

Maybe the changes done in #3546 accidentally fixed this

Not sure... I know for a fact that I never changed any offsets though. I don't particularly care how it was fixed, so much that it was fixed

@Hundrec
Copy link
Contributor

Hundrec commented Oct 13, 2024

After playing the game on both a PC and a laptop at the same time (both set to 300 fps), I've found that devices with weaker performance lag behind over the course of the song. I think this has to do with the actual framerate the device is reaching as well as its load times for assets and events.

Maybe running this timing test with different framerate caps and different levels of processing power would yield different results?

Just ran this test again on 0.5.2 and they progressed at the same rate throughout the song.
Hooray!

@Blue2359
Copy link
Author

Thats weird, I still get the same issue on v0.5.2

@Blue2359
Copy link
Author

Blue2359 commented Nov 9, 2024

Fixed in 0.5.3, closing this now..!

@Blue2359 Blue2359 closed this as completed Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: pending triage The bug or PR has not been reviewed yet. type: minor bug Involves a minor bug or issue.
Projects
None yet
Development

No branches or pull requests

8 participants