Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPIKE: Design image and text support (currently disabled in Aim UI) #1171

Open
suprjinx opened this issue Apr 30, 2024 · 4 comments
Open

SPIKE: Design image and text support (currently disabled in Aim UI) #1171

suprjinx opened this issue Apr 30, 2024 · 4 comments
Assignees

Comments

@suprjinx
Copy link
Contributor

suprjinx commented Apr 30, 2024

Suggested on the MLOps slack channel:

Vinay Anantharaman
  [3 days ago](https://mlops-community.slack.com/archives/C05ALNZ1XJN/p1714242785987829)
I noticed that the image and text support was disabled in the AIM UI. I read through the server code I'm guessing at least the AIM UI API portion in the server hasn't been implemented? (edited)
@suprjinx
Copy link
Contributor Author

Presumably we could use artifact support for this?

@dave-gantenbein dave-gantenbein changed the title Add image and text support (currently disabled in Aim UI) SPIKE: Design image and text support (currently disabled in Aim UI) May 13, 2024
@suprjinx suprjinx self-assigned this May 16, 2024
@suprjinx
Copy link
Contributor Author

suprjinx commented May 20, 2024

Some Spike Findings

In general, an Aim's image explorer is similar to the metrics explorer. Aim /runs/search/images will return a stream response of "traces" corresponding to each image sequence. The UI allows various settings for density, index range, etc, in the request. The image itself is returned as a path (S3 or say network volume path), along with meta data such as 'caption', 'height', 'width', etc.

To support this, we will need MLflow api logging capability for storing the path and metadata. The image itself can be stored as artifact, directly to S3 or local using the existing client methods -- so likely a two-phase save, where we first store artifact and then log it as image. These could be consolidated in one function in the FasttrackML client.

Test coverage in the Aim Python tests will give us a good starting point for compatibility in the UI. Just add this to tests/integration/python/config.json: tests/api/test_run_images_api.py. Our patch will need to provide a new implementation of the fixtures method, generate_image_set.

As far as "text support", Aim does not seem to have explorer-level support for text artifacts.

@dave-gantenbein
Copy link

@suprjinx can we turn this into a list of tickets in the public repo? I'm happy to work with you on it next week.

@suprjinx
Copy link
Contributor Author

@dave-gantenbein added this epic and some children #1230

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants