Generalise the test framework (#72)

G-Research · Feb 15, 2024 · 367eb98 · 367eb98
1 parent 10808cb
commit 367eb98
Show file tree

Hide file tree

Showing 11 changed files with 13 additions and 10 deletions.
diff --git a/tests/FSharp.Analyzers.Tests/Common.fs b/tests/FSharp.Analyzers.Tests/Common.fs
@@ -7,6 +7,9 @@ open System.Threading.Tasks
 open NUnit.Framework
 open FSharp.Analyzers.SDK
 
+[<Literal>]
+let framework = "net7.0"
+
 let shouldUpdateBaseline () =
     Environment.GetEnvironmentVariable "TEST_UPDATE_BSL"
     |> Option.ofObj

diff --git a/tests/FSharp.Analyzers.Tests/DisposedBeforeAsyncRunAnalyzerTests.fs b/tests/FSharp.Analyzers.Tests/DisposedBeforeAsyncRunAnalyzerTests.fs
@@ -13,7 +13,7 @@ let mutable projectOptions : FSharpProjectOptions = FSharpProjectOptions.zero
 [<SetUp>]
 let Setup () =
     task {
-        let! options = mkOptionsFromProject "net7.0" []
+        let! options = mkOptionsFromProject framework []
         projectOptions <- options
     }
 

diff --git a/tests/FSharp.Analyzers.Tests/ImmutableCollectionEqualityAnalyzerTests.fs b/tests/FSharp.Analyzers.Tests/ImmutableCollectionEqualityAnalyzerTests.fs
@@ -13,7 +13,7 @@ let mutable projectOptions : FSharpProjectOptions = FSharpProjectOptions.zero
 [<SetUp>]
 let Setup () =
     task {
-        let! options = mkOptionsFromProject "net7.0" []
+        let! options = mkOptionsFromProject framework []
         projectOptions <- options
     }
 

diff --git a/tests/FSharp.Analyzers.Tests/JsonSerializerOptionsAnalyzerTests.fs b/tests/FSharp.Analyzers.Tests/JsonSerializerOptionsAnalyzerTests.fs
@@ -17,7 +17,7 @@ module JsonSerializerOptionsAnalyzerTests =
         task {
             let! options =
                 mkOptionsFromProject
-                    "net7.0"
+                    framework
                     [
                         {
                             Name = "System.Text.Json"

diff --git a/tests/FSharp.Analyzers.Tests/LoggingArgFuncNotFullyAppliedAnalyzerTests.fs b/tests/FSharp.Analyzers.Tests/LoggingArgFuncNotFullyAppliedAnalyzerTests.fs
@@ -17,7 +17,7 @@ module LoggingArgFuncNotFullyAppliedAnalyzerTests =
         task {
             let! options =
                 mkOptionsFromProject
-                    "net7.0"
+                    framework
                     [
                         {
                             Name = "Microsoft.Extensions.Logging"

diff --git a/tests/FSharp.Analyzers.Tests/LoggingTemplateMissingValuesAnalyzerTests.fs b/tests/FSharp.Analyzers.Tests/LoggingTemplateMissingValuesAnalyzerTests.fs
@@ -17,7 +17,7 @@ module LoggingTemplateMissingValuesAnalyzerTests =
         task {
             let! options =
                 mkOptionsFromProject
-                    "net7.0"
+                    framework
                     [
                         {
                             Name = "Microsoft.Extensions.Logging"

diff --git a/tests/FSharp.Analyzers.Tests/StringAnalyzerTests.fs b/tests/FSharp.Analyzers.Tests/StringAnalyzerTests.fs
@@ -13,7 +13,7 @@ let mutable projectOptions : FSharpProjectOptions = FSharpProjectOptions.zero
 [<SetUp>]
 let Setup () =
     task {
-        let! options = mkOptionsFromProject "net7.0" []
+        let! options = mkOptionsFromProject framework []
         projectOptions <- options
     }
 

diff --git a/tests/FSharp.Analyzers.Tests/TypeAnnotateStringFunctionAnalyzerTests.fs b/tests/FSharp.Analyzers.Tests/TypeAnnotateStringFunctionAnalyzerTests.fs
@@ -13,7 +13,7 @@ let mutable projectOptions : FSharpProjectOptions = FSharpProjectOptions.zero
 [<SetUp>]
 let Setup () =
     task {
-        let! options = mkOptionsFromProject "net7.0" []
+        let! options = mkOptionsFromProject framework []
 
         projectOptions <- options
     }

diff --git a/tests/FSharp.Analyzers.Tests/TypedInterpolatedStringsAnalyzerTests.fs b/tests/FSharp.Analyzers.Tests/TypedInterpolatedStringsAnalyzerTests.fs
@@ -13,7 +13,7 @@ let mutable projectOptions : FSharpProjectOptions = FSharpProjectOptions.zero
 [<SetUp>]
 let Setup () =
     task {
-        let! options = mkOptionsFromProject "net7.0" []
+        let! options = mkOptionsFromProject framework []
         projectOptions <- options
     }
 

diff --git a/tests/FSharp.Analyzers.Tests/UnionCaseAnalyzerTests.fs b/tests/FSharp.Analyzers.Tests/UnionCaseAnalyzerTests.fs
@@ -15,7 +15,7 @@ module UnionCaseAnalyzerTests =
     [<SetUp>]
     let Setup () =
         task {
-            let! options = mkOptionsFromProject "net7.0" []
+            let! options = mkOptionsFromProject framework []
 
             projectOptions <- options
         }

diff --git a/tests/FSharp.Analyzers.Tests/VirtualCallAnalyzerTests.fs b/tests/FSharp.Analyzers.Tests/VirtualCallAnalyzerTests.fs
@@ -15,7 +15,7 @@ module VirtualCallAnalyzerTests =
     [<SetUp>]
     let Setup () =
         task {
-            let! options = mkOptionsFromProject "net7.0" []
+            let! options = mkOptionsFromProject framework []
 
             projectOptions <- options
         }