Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ Don't make API request if no GCNotify API or template ID key present #11654

Closed
2 tasks
petertgiles opened this issue Sep 26, 2024 · 0 comments · Fixed by #12235
Closed
2 tasks

♻️ Don't make API request if no GCNotify API or template ID key present #11654

petertgiles opened this issue Sep 26, 2024 · 0 comments · Fixed by #12235
Assignees
@mnigh
Labels
debt Refactor or improve existing code.

Comments

@petertgiles
Copy link
Contributor

♻️ Debt/Refactor

Our app will make an API request even if it doesn't have an API key or template ID to use. This is wasteful and we should not make a reqeust in that case.

🕵️ Details

image

🙋‍♀️ Proposed Solution

🌎 Localization

✅ Acceptance Criteria

  • Just log an error if the API key is missing but don't make the API request.
  • Just log an error if the template ID is missing but don't make the API request.

🛑 Blockers

Blocked By
Preview Give feedback
No tasks being tracked yet.
@petertgiles petertgiles added the debt Refactor or improve existing code. label Sep 26, 2024
@tristan-orourke tristan-orourke moved this to 🏭 Ready for Estimate in GC Digital Talent Sep 27, 2024
@tristan-orourke tristan-orourke moved this from 🏭 Ready for Estimate to 📋 Ready for Dev in GC Digital Talent Oct 2, 2024
@mnigh mnigh self-assigned this Dec 10, 2024
@mnigh mnigh moved this from 📋 Ready for Dev to 🏗 In progress in GC Digital Talent Dec 10, 2024
@mnigh mnigh mentioned this issue Dec 10, 2024
Merged
@mnigh mnigh moved this from 🏗 In progress to 👀 In review in GC Digital Talent Dec 10, 2024
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in GC Digital Talent Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mnigh mnigh

Labels
debt Refactor or improve existing code.
Projects
GC Digital Talent
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Debt] Wraps GC Notify API request in conditionals GCTC-NTGC/gc-digital-talent
2 participants
@mnigh @petertgiles