Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add smooth scrolling support #164

Closed
thayusdev opened this issue Jan 25, 2022 · 7 comments · Fixed by #201
Closed

Add smooth scrolling support #164

thayusdev opened this issue Jan 25, 2022 · 7 comments · Fixed by #201
Assignees
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@thayusdev
Copy link

thayusdev commented Jan 25, 2022

Describe the problem you're trying to solve.

When you scroll down using the mouse wheel, the page juts down, instead of scrolling smoothly.

Tell us which solutions you've explored, the solution you would pick, and why you think it would be the best for everyone.

I think that making the scroll smoother would make the text easier to read, since when it juts down, you lose your place and it takes a quick second to get back to where you were.

@NathanLovato NathanLovato added enhancement New feature or request good first issue Good for new contributors wontfix This will not be worked on and removed good first issue Good for new contributors labels Jan 25, 2022
@NathanLovato
Copy link
Contributor

NathanLovato commented Jan 26, 2022

@pycbouh and I discussed this. This feature should most likely be part of Godot as scrollbars are implemented in Godot and directly react to mouse wheel events. So it's something we consider work to do on the engine rather than this app.

As a result, for now, we won't try to add this to the app itself with GDScript.

@SpyrexDE
Copy link
Contributor

I also think this is a big problem. I developed my own SmoothScroll plugin some time ago. However, it is far from complete, but could be used as a basis for such a feature.

@SpyrexDE
Copy link
Contributor

I will work on that, already making great progress!

@NathanLovato
Copy link
Contributor

Thanks for trying. I've assigned you to the issue. Just to check, @pycbouh, what do you think? Do you think we should only do this upstream in Godot, or this would be okay to try in GDScript, client-side?

@YuriSizov
Copy link
Contributor

We can try, as long as it doesn't disrupt our scenes. User-side hacks for something that should be resolved between the engine and the host platform have a non-insignificant chance of breaking in unexpected ways. So it's important that we can remove it without too much hassle.

@NathanLovato
Copy link
Contributor

Makes sense. @SpyrexDE could you try to make sure this works mostly as a library and has minimal tangling with the client code, in case we need to remove it later?

@SpyrexDE
Copy link
Contributor

Yeah, will try that. In the current state, it's just a script attached to a default scroll container.

@NathanLovato NathanLovato linked a pull request Jan 28, 2022 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants