fix: throttle scroll events #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should help fix issues with touchpads firing too many scroll events on some web browsers
|
@Xananax could you test this one and tell me if it helps on Chrome for you? You can control the throttling in SmoothScrollContainer.gd by changing |
|
On chrome, it works perfectly well. On Firefox, I get occasional jumps of about 20px up or down from time to time. It's mainly noticeable while testing, or if someone wants to scroll to bottom very fast. If someone's just reading and scrolling at reading speed, it will seem a bit glitchy sometimes, but it's fine. I don't think it's worth exploring this glitch, there are too many confounding factors (hardware, performance, javascript event handling, Godot, ...). I deem the current behavior satisfying. |
This was referenced Feb 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help fix issues with touchpads firing too many scroll events on some web browsers.
Should fix #114 but needs testing.