choose start date automatically, based on end date + period #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyrasd
force-pushed
the
feature/automatic-start-date
branch
from
3d24e13 to
4761ee2
Compare
the start time ich calculated such that: start + n*period ~= end
tyrasd
force-pushed
the
feature/automatic-start-date
branch
from
4761ee2 to
43d9752
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes it can be annoying that the timestamps in a query results are foremost based on the start date: especially for larger periods (e.g. a yearly interval), the difference between the last included timestamp in the query and the latest available OSM data in the database/ohsome-API can be quite large. Typically, it is more desirable to get the most recent available data.
This PR solves this by calculating the start data automatically (if not manually set), based on the given end date and the given period.
metadatarequest)start + n*period ~= end, see Data Freeze to 2023-10-07 #32 (comment). (Typically it will work out such that the determined start date matches the end date exactly, but there are some edge cases like February 29 on non-leap years, or a 31th of a month with <31 days, which may result in a few days of variance.)