Disk interface is being overriden when set to none

[mrchrd]

I'm creating an appliance that requires extra options for the virtio-scsi-pci and scsi-hd devices. I set those in the qemu.options field and also set qemu.hd*_disk_interface: none in the gns3a file, and then let GNS3 set the QEMU -drive option. The result I would expect is that GNS3 sets only the -drive with if=none and does not set the -device options. However, this piece of code overrides the disk interfaces to ide:

# fail-safe: use "ide" if there is a disk image and no interface type has been explicitly configured
if interface == "none":
    interface = "ide"
    setattr(self, "hd{}_disk_interface".format(drive), interface)

Because none is actually an accepted and useful value for QEMU, I think it should not be replaced when it is set explicitely.

[grossmj]

Fixed, thanks 👍