Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Queries: 1. Refactor Core DAOs (Notifications and Users) #1320

Closed
5 tasks
xlorepdarkhelm opened this issue Sep 9, 2024 · 0 comments · Fixed by #1362
Closed
5 tasks

Upgrade Queries: 1. Refactor Core DAOs (Notifications and Users) #1320

xlorepdarkhelm opened this issue Sep 9, 2024 · 0 comments · Fixed by #1362
Assignees

Comments

@xlorepdarkhelm
Copy link
Contributor

xlorepdarkhelm commented Sep 9, 2024

Converting queries to SQLAlchemy 2.0 standards is a complex process, this issue is for updating the following modules:

  • app/dao/notifications_dao.py
  • app/dao/users_dao.py

These modules require the following steps to be done for them (explained in Upgrade SQLAlchemy queries to 2.0 standards #1319):

  1. Refactor SELECT Statements
  2. Refactor INSERT Statements
  3. Refactor UPDATE Statements
  4. Refactor DELETE Statements
  5. Refactor Utility Functions
  6. Use Transactions Correctly

Acceptance Criteria:

  • Make the necessary changes to the modules
  • Double check that running the migrations and tests still work as expected with no deviation from the previous code
  • Verify that a deploy to staging works with the changes once merged

Security Considerations

As SQLAlchemy 2.0+ is now released, the older 1.4 way is deprecated, and may not receive security updates, as well as are expected to be completely phased out of the codebase in the relatively near future.

Other than that, there's really nothing. The end goal should be that this changes these modules and doesn't impact anything else.

@xlorepdarkhelm xlorepdarkhelm converted this from a draft issue Sep 9, 2024
@terrazoon terrazoon self-assigned this Oct 11, 2024
@terrazoon terrazoon moved this from 🌱 New to 🏗 In progress (WIP: ≤ 3 per person) in Notify.gov product board Oct 11, 2024
@terrazoon terrazoon linked a pull request Oct 11, 2024 that will close this issue
@terrazoon terrazoon moved this from 🏗 In progress (WIP: ≤ 3 per person) to 👀 In review in Notify.gov product board Oct 11, 2024
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Notify.gov product board Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants