Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

πŸ” 인증제 폼을 찾을 수 μ—†λŠ” 경우, 빈 배열을 λ°˜ν™˜ #413

Merged
merged 1 commit into from
Sep 26, 2024
Merged

πŸ” 인증제 폼을 찾을 수 μ—†λŠ” 경우, 빈 배열을 λ°˜ν™˜ #413

merged 1 commit into from
Sep 26, 2024

Conversation

enbraining
Copy link
Member

@enbraining enbraining commented Sep 24, 2024 •
edited
Loading

πŸ’‘ λ°°κ²½ 및 κ°œμš”

ν΄λΌμ΄μ–ΈνŠΈμ—μ„œ 인증제 νŽ˜μ΄μ§€μ— λ“€μ–΄κ°”μ„λ•Œ 404κ°€ λœ¨λŠ” 것을 ν™•μΈν–ˆκ³ ,
μ„œλ²„λ₯Ό ν™•μΈν•΄λ³΄λ‹ˆ 인증제 폼이 μ—†λŠ” 경우 500이 λ°˜ν™˜λ˜κ³  μžˆλŠ” 문제λ₯Ό λ°œκ²¬ν•΄μ„œ,
μ—†λŠ” 경우 빈 배열을 λ°˜ν™˜ν•˜λ„λ‘ μˆ˜μ •ν–ˆμŠ΅λ‹ˆλ‹€.

Resolves: #412

πŸ™‹β€β™‚οΈ λ¦¬λ·°λ…ΈνŠΈ

οΏ½usecase의 λ°˜ν™˜κ°’μ„ nullable둜 λ³€κ²½ν•˜λŠ” 방법도 μƒκ°ν•΄λ΄€μ§€λ§Œ μˆ˜μ •ν•  것이 λ§Žμ•„μ§ˆ 것 κ°™μ•„μ„œ,
runCatching ν•¨μˆ˜λ₯Ό μ΄μš©ν•΄μ„œ μ˜ˆμ™Έ μ²˜λ¦¬ν•˜μ˜€μŠ΅λ‹ˆλ‹€.

βœ… PR 체크리슀트

ν…œν”Œλ¦Ώ 체크리슀트 말고도 μΆ”κ°€μ μœΌλ‘œ ν•„μš”ν•œ μ²΄ν¬λ¦¬μŠ€νŠΈλŠ” μΆ”κ°€ν•΄μ£Όμ„Έμš”!

  • 이 μž‘μ—…μ„ ν•˜κ³ λ‚˜μ„œ κ³΅μœ ν•΄μ•Όν•  νŒ€μ›λ“€μ—κ²Œ κ³΅μœ λ˜μ—ˆλ‚˜μš”? (e.g. "API 개발 μ™„λ£Œλμ–΄μš”", "ν™˜κ²½κ°’ μΆ”κ°€λ˜μ—ˆμ–΄μš”")
  • μž‘μ—…ν•œ μ½”λ“œκ°€ μ •μƒμ μœΌλ‘œ λ™μž‘ν•˜λ‚˜μš”?
  • Merge λŒ€μƒ λΈŒλžœμΉ˜κ°€ μ˜¬λ°”λ₯Έκ°€μš”?
  • PRκ³Ό κ΄€λ ¨ μ—†λŠ” μž‘μ—…μ΄ μžˆμ§€λŠ” μ•Šλ‚˜μš”?

@enbraining enbraining added 1️⃣ Priority: High μš°μ„ μˆœμœ„ - 상 🐞 Bug 버그 λ°œμƒ labels Sep 24, 2024
@enbraining enbraining self-assigned this Sep 24, 2024
@enbraining enbraining linked an issue Sep 24, 2024 that may be closed by this pull request
인증제 폼이 ν•˜λ‚˜λ„ 없을 λ•Œ 500이 뜸 #412
Closed
@enbraining enbraining merged commit 871482b into develop Sep 26, 2024
1 check passed
@enbraining enbraining deleted the hotfix/412-empty-authentication-form-500 branch September 26, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louis7308 louis7308 Awaiting requested review from louis7308

@Huuuunee Huuuunee Awaiting requested review from Huuuunee

@ani2689 ani2689 Awaiting requested review from ani2689

Assignees

@enbraining enbraining

Labels
1️⃣ Priority: High μš°μ„ μˆœμœ„ - 상 🐞 Bug 버그 λ°œμƒ
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

인증제 폼이 ν•˜λ‚˜λ„ 없을 λ•Œ 500이 뜸
1 participant
@enbraining