Skip to content

Commit

Permalink
CI : Remove htmlproofer --check-html option
Browse files Browse the repository at this point in the history
This feature was removed in `htmlproofer` 4.0. From the developer :

> This was intentionally removed as part of the html-proofer 4.0 major release. It was removed because, over the years, it has provided more false positives than actual errors. HTML 5 engines in particular are much more forgiving of broken HTML, and so it logging the four or five small errors this check actual looked for was not worth the trouble of maintainence (I'm just one developer). I know of no other tools which duplicate the feature but there might be some W3C validators which run a similar check.

We are much more interested in the link and image validation features, which continue to work.

Also remove `--empty-alt-ignore`, which I believe is now the default behaviour, based on gjtorikian/html-proofer#717. And rename `--url-ignore` to `--ignore-urls`, because.
  • Loading branch information
johnhaddon committed Sep 14, 2022
1 parent a8b412e commit 4f099c0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,4 +36,4 @@ jobs:

- name: Check
run: |
htmlproofer ./_site --only-4xx --check-html --empty-alt-ignore --url-ignore "/vimeo.com/"
htmlproofer ./_site --only-4xx --ignore-urls "/vimeo.com/"

0 comments on commit 4f099c0

Please sign in to comment.