Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YouTube app crash #110

Closed
PavelMasuk opened this issue Mar 9, 2024 · 24 comments
Closed

YouTube app crash #110

PavelMasuk opened this issue Mar 9, 2024 · 24 comments
Assignees
Labels
bug Something isn't working

Comments

@PavelMasuk
Copy link

Describe the bug
App crashes at the moment of opening the video

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://github.com/qnblackcat/uYouPlus
  2. Build an app using instructions from here https://github.com/qnblackcat/uYouPlus/wiki/Building (you can find decrypted youtube ipa 19.08.2 here https://github.com/qnblackcat/Decrypted-IPAs)
  3. Install the app via AltStore
  4. Open the app and open any video, app will crash
  5. If you disable SponsorBlock and relaunch the app, everything will work correctly

Please complete the following information:

  • iOS Version: 17.4
  • Device: IPhone 14 Pro Max
  • YouTube Version 19.08.2 (the same behaviour with 19.09.4)
  • iSponsorBlock Version: not sure how to check it but I guess qnblackcat's script downloads the latest one
@dayanch96
Copy link
Contributor

crashlog?

@Glenta
Copy link

Glenta commented Mar 14, 2024

@dayanch96 I have the same issue but using Balackburn's YTLitePlus. I have opened an issue with all my details and crashlog https://github.com/Balackburn/YTLitePlus/issues/92

@dayanch96
Copy link
Contributor

image
same old formatting issue.

can you check what returns this link please @Glenta

SponsorBlock request

@Glenta
Copy link

Glenta commented Mar 15, 2024

@dayanch96 I get the following in safari:
[{"category":"filler","actionType":"skip","segment":[6.404,12.866],"UUID":"141e0ed0829b30bf6f0728c89506dc2db502e1c1c93836607cd9d38d72089a6b7","videoDuration":2105.721,"locked":0,"votes":0,"description":""},{"category":"sponsor","actionType":"skip","segment":[59.692,64.989],"UUID":"8da0a2ca494f4e63fbc149e67226669cbe3ef8f088dea354c7d270c0560fef3d7","videoDuration":2105.721,"locked":1,"votes":6,"description":""},{"category":"sponsor","actionType":"skip","segment":[2076.895,2085.366],"UUID":"e923873d8a47eb438369ed063c7a265800e62209075e5cb4902750d729cb94647","videoDuration":2105.721,"locked":1,"votes":2,"description":""},{"category":"poi_highlight","actionType":"skip","segment":[1385.924,1385.924],"UUID":"8a480cace3869402556c827b067439823afcb7cde6f625fc3ae0470cae71aaab7","videoDuration":2105.721,"locked":0,"votes":3,"description":""}]

@NekoRem
Copy link

NekoRem commented Mar 15, 2024

Got the same on jailbroken version on his repo.

@skinnyceps
Copy link

skinnyceps commented Mar 19, 2024

Now it won’t crash but the plugin is not working, it doesn’t show the colors on the timeline of the videos and it’s not skipping the content.
EDIT: iPhone 15 pro max on iOS 17.4 - using latest YTLitePlus

@dayanch96
Copy link
Contributor

dayanch96 commented Mar 19, 2024

Now it won’t crash but the plugin is not working, it doesn’t show the colors on the timeline of the videos and it’s not skipping the content. EDIT: iPhone 15 pro max on iOS 17.4 - using latest YTLitePlus

using a mod and leaving a report to the original repo is not the best idea

looks like they just use isb directly. make sure your isb enabled in its settings

@gmanc2
Copy link

gmanc2 commented Mar 19, 2024

I'm experiencing crashes on uYouPlus due to iSponsorBlock. The issue can be referenced here: qnblackcat/uYouPlus#1361

@dayanch96
Copy link
Contributor

Looks like there something new in notched devices interface. I cant test it since i have only 4.7 inch device

@enriicsolaa
Copy link

enriicsolaa commented Mar 22, 2024

Compiled and tested the latest commit #111 and nothing else. The error keeps appearing.
Tested in iPhone 15 pro - 17.1.1, latest IPA decrypted by me v19.10.7, tried injected with ellekit, substitute and substrate. Nothing else.
Tested in jailbroken iPhone 8 - 16.7.2, w/palera1n rootless, YT app from AppStore v19.10.7. Tested with the latest build available in the official repo, and works fine without crashes in no notched/dynamic island phone. The same with my own compiled build with the latest commit.

In the two cases used the latest Alderis build from Chariz repo.
So sorry... I can't test anymore. My unique notched/dynamic island phone is the ip15pro and it's in a non-exploitable version.

(From ignorance), it seems like a bug that has to do with screen resolutions with notch and dynamic island.
It only occurs when you have started using the tweak for the first time a while ago, and after this, when watching a video (the shorts work perfectly), the app crashes.

I hope my little analysis can help in some way :)

EDIT: The error now appears in the iPhone 8. Maybe is not a isolated error from notched/dynamic island devices.

@skinnyceps
Copy link

Ok rolled back to an old version of YT and this is not happening anymore so they broke it with the latest versions only. I will stay there till it’s fixed ✌️

@PavelMasuk
Copy link
Author

@skinnyceps could You please tell what YT version You are using? And did You research what is the latest working version?

@skinnyceps
Copy link

@skinnyceps could You please tell what YT version You are using? And did You research what is the latest working version?

Idk the latest version working rn, on 19.02.01 it’s working, I had that IPA saved tried to see if it would works and it works

@dayanch96
Copy link
Contributor

dayanch96 commented Mar 27, 2024

its not solution but workaround, you can spoof version to 18.x.x and it should work

%hook YTVersionUtils
+ (NSString *)appVersion {
    return @"18.18.2";
}
%end

PS: As far as I know problem in new interface but can’t test it since I don’t have notched device. This issue doesn’t occur on 4.7inch devices

@huandney
Copy link

I’m not sure if it’s a coincidence, but today I updated YTLitePlus to version 19.10.7 and YouTube started crashing. I reverted back to several older versions, and the problem with iSponsorBlock activated occurs in all the tested versions even after downgrading, on my iPhone 15 Pro. Curiously, I hadn’t had this problem before.

@skinnyceps
Copy link

@huandney try the version I posted above, it works for me

@enriicsolaa
Copy link

its not solution but workaround, you can spoof version to 18.x.x and it should work

%hook YTVersionUtils
+ (NSString *)appVersion {
    return @"18.18.2";
}
%end

PS: As far as I know problem in new interface but can’t test it since I don’t have notched device. This issue doesn’t occur on 4.7inch devices

Headers needed? (I'm very newbie in theos)

@dayanch96
Copy link
Contributor

Headers needed? (I'm very newbie in theos)

no

@PavelMasuk
Copy link
Author

its not solution but workaround, you can spoof version to 18.x.x and it should work

%hook YTVersionUtils
+ (NSString *)appVersion {
    return @"18.18.2";
}
%end

PS: As far as I know problem in new interface but can’t test it since I don’t have notched device. This issue doesn’t occur on 4.7inch devices

Thank You so much, it actually works! Not gonna close the issue since the bug is not fixed yet and this workaround can break with future versions but i guess we can use it for now.

@Excremation
Copy link

Also getting this on uYou 19.10.7_3.0.3, iPhone 13 Pro, 15.4.1. Will downgrade YouTube for now.

@enriicsolaa
Copy link

I find a solution in r/sideload. A user proposed this:

Hi everyone! I’ve managed to find a fix so the SponsorBlock works on the latest version:

Disable SponsorBlock exit the YouTube app, go back to the YouTube app and play any video and while the video is playing minimize the video by swiping down on the video so it goes in the MiniPlayer mode at the bottom of the app and then enable sponsorblock again (while the video is playing) then exit the yt app and voila SponsorBlock is working again. If after doing all these steps the SponsorBlock doesn’t start showing in the seek bar just exit the app couple of times and it should work.

https://www.reddit.com/r/sideloaded/s/DodjdVr5hh

@Excremation
Copy link

I find a solution in r/sideload. A user proposed this:

Hi everyone! I’ve managed to find a fix so the SponsorBlock works on the latest version:

Disable SponsorBlock exit the YouTube app, go back to the YouTube app and play any video and while the video is playing minimize the video by swiping down on the video so it goes in the MiniPlayer mode at the bottom of the app and then enable sponsorblock again (while the video is playing) then exit the yt app and voila SponsorBlock is working again. If after doing all these steps the SponsorBlock doesn’t start showing in the seek bar just exit the app couple of times and it should work.

https://www.reddit.com/r/sideloaded/s/DodjdVr5hh

Didn’t work for me unfortunately. Just instantly crashes when playing a video again. :(

@dayanch96
Copy link
Contributor

Fixed. re-build using latest commit and enjoy

@Excremation
Copy link

Fixed. re-build using latest commit and enjoy

Forgive my ignorance I’m new to GitHub, but how do I rebuild with this? I’ve forked your repo but there are no build actions in the actions page like there are with uYou. Sorry if I’m being dumb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests