Skip to content

Commit

Permalink
CI: Drop GHC 8.8 (#1414)
Browse files Browse the repository at this point in the history
This is motivated by a couple of reasons:

* GHC 8.8 on Windows suffers from a bug that can cause building certain code
  to loop forever or even segfault. As far as I can tell, this bug doesn't
  affect GHC 8.10 or later, so dropping 8.8 is a fairly reliable way to avoid
  this problem.
* GHC 8.8 is outside of the three most recent stable GHC releases, so it
  doesn't make as much sense to keep maintaining support for it.
  • Loading branch information
RyanGlScott authored Aug 25, 2022
1 parent d04aa87 commit 46d2e05
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 318 deletions.
11 changes: 4 additions & 7 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -59,11 +59,8 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-22.04, macos-12, windows-2019]
ghc-version: ["8.8.4", "8.10.7", "9.0.2", "9.2.4"]
ghc-version: ["8.10.7", "9.0.2", "9.2.4"]
exclude:
# https://gitlab.haskell.org/ghc/ghc/-/issues/18550
- os: windows-2019
ghc-version: 8.10.7
- os: windows-2019
ghc-version: 9.0.2
- os: windows-2019
Expand All @@ -72,7 +69,7 @@ jobs:
# We include one job from an older Ubuntu LTS release to increase our
# coverage of possible Linux configurations.
- os: ubuntu-22.04
ghc-version: 8.8.4
ghc-version: 8.10.7
outputs:
test-lib-json: ${{ steps.test-lib.outputs.targets-json }}
env:
Expand Down Expand Up @@ -206,13 +203,13 @@ jobs:
if-no-files-found: error
retention-days: ${{ needs.config.outputs.retention-days }}

- if: matrix.ghc-version == '8.8.4'
- if: matrix.ghc-version == '8.10.7'
uses: actions/upload-artifact@v2
with:
path: dist/bin
name: ${{ runner.os }}-dist-bin

- if: matrix.ghc-version == '8.8.4'
- if: matrix.ghc-version == '8.10.7'
uses: actions/upload-artifact@v2
with:
path: bin
Expand Down
6 changes: 3 additions & 3 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -22,15 +22,15 @@ RUN z3 --version
ARG CRYPTOLPATH="/cryptol/.cryptol"
ENV LANG=C.UTF-8 \
LC_ALL=C.UTF-8
COPY cabal.GHC-8.8.4.config cabal.project.freeze
COPY cabal.GHC-8.10.7.config cabal.project.freeze
RUN mkdir -p /home/cryptol/.local/bin && \
curl -L https://downloads.haskell.org/~ghcup/0.1.17.7/x86_64-linux-ghcup-0.1.17.7 -o /home/cryptol/.local/bin/ghcup && \
chmod +x /home/cryptol/.local/bin/ghcup
RUN mkdir -p /home/cryptol/.ghcup && \
ghcup --version && \
ghcup install cabal 3.6.2.0 && \
ghcup install ghc 8.8.4 && \
ghcup set ghc 8.8.4
ghcup install ghc 8.10.7 && \
ghcup set ghc 8.10.7
RUN cabal v2-update && \
cabal v2-build -j cryptol:exe:cryptol && \
cp $(cabal v2-exec which cryptol) rootfs/usr/local/bin && \
Expand Down
308 changes: 0 additions & 308 deletions cabal.GHC-8.8.4.config

This file was deleted.

0 comments on commit 46d2e05

Please sign in to comment.