Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

toNameDisp looks wrong #1047

Closed
yav opened this issue Jan 26, 2021 · 1 comment
Closed

toNameDisp looks wrong #1047

yav opened this issue Jan 26, 2021 · 1 comment
Assignees
@yav
Labels
UX Issues related to the user experience (e.g., improved error messages)

Comments

@yav
Copy link
Member

yav commented Jan 26, 2021

This function does not seem to be taking into account the different namespace, and it looks like it will show names incorrectly if the same name is used both as a value and as a type, and the one wants to be showed qualified but the other unqualified.

More generally, we may want to refactor naming environment to be a map rather than a record:

type NamingEnv = Map NameSpace (Map PName [Name])
@yav yav self-assigned this Jan 26, 2021
@robdockins robdockins added the UX Issues related to the user experience (e.g., improved error messages) label Feb 9, 2021
@yav
Copy link
Member Author

yav commented Apr 6, 2021

Should be fixed with the merge of the nested modules PR

@yav yav closed this as completed Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yav yav

Labels
UX Issues related to the user experience (e.g., improved error messages)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yav @robdockins