Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source position tracking #698

Closed
robdockins opened this issue Apr 3, 2020 · 3 comments
Closed

Source position tracking #698

robdockins opened this issue Apr 3, 2020 · 3 comments
Assignees
@robdockins
Labels
feature request Asking for new or improved functionality

Comments

@robdockins
Copy link
Contributor

As far as I can tell, Cryptol discards source file position information during typechecking. It would be convenient for later error-reporting purposes, etc., if we retained source position information through the typechecked AST and into evaluation.
@robdockins robdockins added the feature request Asking for new or improved functionality label Apr 3, 2020
@atomb atomb added this to the 2.9.0 milestone May 5, 2020
@robdockins
Copy link
Contributor Author

@atomb, I think this might be too large a change to try to get in before the 2.9 release. I don't think it's especially complicated, but it will touch a lot of code.

What do you think about slipping this one?

@atomb
Copy link
Contributor

atomb commented Jun 29, 2020

Yeah, postponing it seems reasonable.

@atomb atomb modified the milestones: 2.9.0, 3.0.0 Jun 29, 2020
@atomb atomb removed this from the 2.10.0 milestone Sep 22, 2020
@robdockins robdockins self-assigned this Nov 19, 2020
@robdockins robdockins mentioned this issue Nov 25, 2020
Closed
@robdockins
Copy link
Contributor Author

Fixed via #995

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robdockins robdockins

Labels
feature request Asking for new or improved functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@atomb @robdockins