feat(notifications): finish migrating gql functionality #3821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
UncleSamtoshi
commented
Jan 11, 2024
•
UncleSamtoshi
commented
- switch from account settings to user settings
- add notificationSettings to User
- add userEnableNotificationChannel mutation
- add userDisableNotificationCategory mutation
- add userEnableNotificationCategory mutation
dolcalmi
reviewed
Jan 12, 2024
bodymindarts
previously approved these changes
Jan 12, 2024
| @@ -13,50 +13,149 @@ pub struct Query; | |||
| #[Object] | |||
| impl Query { | |||
| #[graphql(entity)] | |||
| async fn consumer_account(&self, id: ID) -> Option<ConsumerAccount> { | |||
There was a problem hiding this comment.
For backwards compatibility won't we need to keep it on consumer_account as well?
Can still return the same
app
.notification_settings_for_user(GaloyUserId::from(self.id.0.clone()))
.await?;
There was a problem hiding this comment.
The types are different now so we can't. I think we will need to keep backwards compatibility by keeping it live on core for a period.
There was a problem hiding this comment.
In addition to the mutations on core.
There was a problem hiding this comment.
So core will proxy to notifications I for a while I guess.
bodymindarts
approved these changes
Jan 12, 2024
This was referenced Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.